Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "visibility: hidden" instead of "display:none" to hide the dropdown menu #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LinAlSara
Copy link

Problem
I want to open the dropdown menu by default downwards and only if the dropdown menu list will be at the end of the page (it will be cut & user has to scroll to see the dropdown list) then open it upwards. The problem with the current implementation is that 'display: none' is used which means the dropdown menu does not appear in the dom & therefore I can not detect if the dropdown menu list will be at the end of the page.
So I suggest using visibility: hidden instead of 'display: none'.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.652% when pulling bc1ce75 on LinAlSara:enhancement/UseVisibilityHiddenInsteadOfDisplayNone into 2203ee0 on trendmicro-frontend:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants