Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ssl issue and improve musl builds #720

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Fix ssl issue and improve musl builds #720

merged 1 commit into from
Jan 27, 2021

Conversation

Licenser
Copy link
Member

Pull request

Description

This adds improvements to the package build process to statically link libssl to make the binaries more portable.

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes or other observable changes in behavior

.depignore Show resolved Hide resolved
Copy link
Member

@mfelsche mfelsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is hard to verify for me, but overall it looks legit :)

Crazy magic stuff.

@coveralls
Copy link
Collaborator

coveralls commented Jan 27, 2021

Coverage Status

Coverage remained the same at 80.845% when pulling 48292e2 on packaging-fixes into 3dad488 on main.

@Licenser Licenser merged commit ff6c029 into main Jan 27, 2021
@Licenser Licenser deleted the packaging-fixes branch January 27, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants