Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loadfilename as column s3 #306

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ak-w
Copy link

@ak-w ak-w commented Apr 21, 2021

Add custom script sample code "loaded file name as data from S3 on AWS".

1. Obtain file names and file contents from multiple files in a specific bucket of S3.
the file sample
name: files_aaa_20210401
contents:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L10 - L12 letters are in the same line. Is this intentional?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your check! There need to line break there. I add the line break.

$ td wf push s3_filename_add

And Set the S3 Access key ID and Secret access key to the workflow secret as follows.
Access key ID,Secret access key
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line looks like that isn't a sentence. Is this an intentional line?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to add "Access key ID" and "Secret access key" comments, but I forgot to write them. Thank you.

@ak-w
Copy link
Author

ak-w commented Jun 1, 2021

Sorry for the late. I pushed fixed README.md.

@kamikaseda kamikaseda requested a review from akito19 August 5, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants