SCTP support #82
Open
SCTP support #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about the bug now? |
|
ref.: #81 |
|
@LionNatsu |
| case IPPROTO_SCTP: | ||
| mtrtype = IPPROTO_ICMP; | ||
| break; | ||
| } | ||
| return ActionNone; |
There was a problem hiding this comment.
new feature: here's a new switch key s for SCTP
There was a problem hiding this comment.
Oh, it will surely not work. s conflicted with line 135, the key to Change Packet Size.
|
BTW, why does TCP not emit SIGPIPE? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added codes about SCTP in curses.c and select.c this time, and got SIGPIPE when MTRing to a non-existent address (which causes a loop route between two routers).
I modified net.c, to avoid SIGPIPE, but I don't know if I'm doing the right thing, as I'm not familiar with the whole program.