Add UDP packet size limit #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vassilevsky
force-pushed
the
udp-packet-size-limit
branch
2 times, most recently
from
31f160e to
2282262
Compare
UDP packets cannot exceed MTU. If they do, the app gets
{error,emsgsize} from gen_udp:send. Similar issue:
jaegertracing/jaeger-client-node#124
This commit adds packet size check. Packets are sent
immediately upon reaching max size, even before the end
of batch window.
Size calculation from CollectedMetrics map would've been
costly. I changed the format to binary. Metrics are encoded
into Line Protocol immediately now, instead of right before
sending.
This also helps avoid data loss. The map did not record
all timestamps. It set the most recent timestamp
for all fields of the same measurement.
It also did not honor differences in tags, but I guess
there aren't any when metrics go through Exometer.
vassilevsky
force-pushed
the
udp-packet-size-limit
branch
from
2282262 to
18502dc
Compare
|
We've been using this branch in production for a long time and there were no problems. Could you merge it and release a new version of the Hex package? Thanks! |
|
Thank you :3 |
|
Could you also please release a new version to Hex.pm? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi ☃
This is a fix for #51.
The downside is that data points are no longer combined.
What do you think?