Migrate to rebar3 and use hackney from hex.pm #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is supporting R17 a requirement? I'm not sure what the difference is in deps by using rebar vs rebar3. |
tverlaan
changed the title
tverlaan
changed the title
tverlaan
force-pushed
the
rebar3_with_hex
branch
from
2bc8900 to
6c66d6a
Compare
|
Looks |
tverlaan
force-pushed
the
rebar3_with_hex
branch
from
6c66d6a to
babb5f0
Compare
|
The next hackney release (> 1.8.6) will depend on idna 5.1.0 which doesn't contain minimum OTP version. However next mayor version will only support Erlang >= 19 as per benoitc/hackney#425. |
|
Then can you update |
|
Can we now merge this? |
|
@tverlaan sorry for delay. thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a rebar.lock as well as created by rebar3. As discussed in #41