Report in bulk #38
Closed
Report in bulk #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 1, 2017 15:08
|
Hi @jacktang, thank you for your PR. By the way, we already have own bulk write mechanism, see |
surik
reviewed
Mar 2, 2017
| fun({Metric, DataPoints}, {StateAccIn, ErrorsAccIn}) -> | ||
| case maps:get(Metric, Metrics, not_found) of | ||
| {MetricName, Tags} -> | ||
| case maybe_send(Metric, MetricName, Tags, |
There was a problem hiding this comment.
Did you notice that maybe_send has two behaviors depend on batch_window_size?
With batch_window_size=0 each metric from a bulk will be sent in an own request.
With batch_window_size>0 it isn't sent immediately but goes to a buffer to the further sending in one batch.
There was a problem hiding this comment.
@surik you're right. I missed the batch_window_size config. The original code supports the report in bulk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to insert meter data in InfluxDB as one record