Fix two failed unit tests and three mypy errors #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess this method is a remnant from the time that the parent class (DataAccessor) had self.header defined. This is apparently no longer the case.
Will also be tackled when we fix #56, i.e. then the entire ObjectContainer class may be removed.
It should have been 'casa.table' instead of 'aartfaac.table'. This explains why the unit test failed. That folder had not yet been copied into PySE from TraP. At a later stage we may want to introduce a separate 'test/data/accessors' subdirectory, mimicking 'tkp/tests/data/accessors' in TraP.
Should fix #81. Also reformat to stay within 80 characters per line. Comments should start with '# ' (space included).
'accessors' subdirectory within 'test/data', to make the test data more manageable. This mimicks the original setup of test data in TraP.
'test/data'.
within 'test/data'.
'test/data'. Also following linter recommendation to turn instance method into static method.
within 'test/data'. Also some reformatting, adhering to the max. 80 characters per line protocol.
Skiping tests was a workaround until we decided how to handle datasets. We are simply adding them to the repo since they don't change.
suvayu
requested changes
Oct 28, 2024
I'll do an offline merge, in case there are conflicts. |
|
Ah no, I misunderstood the PR. I'll merge this first, then we can look at #87 if there are conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81 and #82