Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new study: Li_2018 #719

Open
wants to merge 29 commits into
base: develop
Choose a base branch
from
Open

Add new study: Li_2018 #719

wants to merge 29 commits into from

Conversation

yangsophieee
Copy link
Collaborator

@yangsophieee yangsophieee commented Jun 7, 2023

Study investigating variation in key hydraulic and carbon economy traits of 12 woody species in Australia across a broad climatic gradient, using a common garden approach.

Questions for review:

  • Unsure what the life_stage is -- they grew plants from seed, seedlings were transplanted in 2016 and then grown and measured until maybe May 2017? So one or two years old. Is it just juvenile?
  • Is there a water_potential_12percent_lost_conductivity? I can only find 50 and 88.
  • Just checking that Ks is sapwood_specific_conductivity, not stem_specific_conductivity? From text: "Kfinal was normalized by the pressure gradient, sapwood area, and stem length to obtain initial and final xylem-specific hydraulic conductivity (Ks, kg m−1 s−1 MPa−1)."
  • Do we have traits for Ψleaf at 50% of maximum stomatal conductance ("Early decline of stomatal conductance; proxy of Ψleaf at which stomata initiate closure") and 10% of maximum stomatal conductance ("Maximum water stress while still maintaining minimal photosynthesis; proxy of complete stomatal closure")?
  • What about Cbranch ('Amount of releasable water of living cells as xylem tension increases') and VIGR ('Stem volume index growth rate, a surrogate of plant growth rate')?
  • I'm a bit confused with the methods for Amax, it says "Leaf net carbon assimilation rate (An)... were measured by placing the leaf into a 2 × 3 cm cuvette supplied with saturating light (1,500 μmol m−2 s−1) and ambient CO2 concentration (420 μmol mol−1)." If it's ambient CO2 then that's not Amax right? But they say it was for An not Amax. In the section before it says the following but I'm not sure what it means: "During this phase, leaf gas exchange characteristics and corresponding leaf water potential (Ψleaf, MPa) were measured periodically until positive net photosynthesis (Amax, μmol m−2 s−1) was no longer detectable."
  • It's unclear to me whether they performed gas exchange measurements on just drought treatment plants or on all of them. "Gas exchange measurements were conducted on recent, fully expanded leaves. During drought stress, the healthiest fully expanded leaf on each individual plant was chosen." I've assumed for replicates that it's all of the plants for now.
  • Need to check taxonomic updates
  • Will the new names, e.g. sapwood_specific_conductivity to sapwood_specific_hydraulic_conductivity be updated when merged or do we need to do that here?

yangsophieee and others added 23 commits May 19, 2023 14:40
* Adding 7 studies with morphological trait data extracted from 7 state and national floras: "SAH_2023", "WAH_2023_1", "WAH_2023_2", "ABRS_2023", "RBGV_2023", "NHNSW_2023", "NTH_2023"

* 30 traits added

* trait values mostly mapped to those developed in vocabulary workshops, but a few additional terms were needed, especially for traits like leaf_base for which we previously had very little data

* branch also includes some preliminary work on fire response traits and edits to water use/hydraulics traits
---------
Co-authored-by: David Coleman <https://github.com/dcol2804>
Co-authored-by: Sophie Yang <[email protected]>
Add large dataset on fire response, seed longevity and reproductive maturity of most taxa in the Northern Territory Herbarium database, compiled from the literature and expert review.
Lizzy emailed the report to the author but he's on leave so merging now! 

---------

Co-authored-by: ehwenk <[email protected]>
Add 3 new studies from Nadia Santini looking at water relations
Contributor has submitted her raw data files and reviewed all reports
---------

Co-authored-by: Sophie Yang <[email protected]>
Add study examining how resprouting and propagule persistence are associated with grassland and shrubland habitats and other environmental and biotic variables. Lizzy has emailed the author and we are awaiting a response.

---------

Co-authored-by: ehwenk <[email protected]>
Add study with seed storage location and fire response data (both resprouting and seedling recruitment) at the plot level after experimental fire treatments. The study also investigated density changes after fire, which I have not mapped.

---------

Co-authored-by: ehwenk <[email protected]>
* edits to traits related to fire response and plant regeneration following one of the AusTraits vocabulary workshops
* major change is renaming all `fire_response` related traits to `resprouting_capacity`
* removing several derived traits that can be recreated from other trait values; in the coming 6 months we will create some scripts showing how current data can be analysed
* remap values for some traits in NSWFRD_2014 to capture more data
---------

Co-authored-by: Sophie Yang <[email protected]>
* add new study: Mitchell_2008
* no contact with data collector
* some problems with archived data - for instance Kl data are identical to Ks, so not used.
---------

Co-authored-by: yangsophieee <[email protected]>
* add new study: Kocacinar_2003
* contacted authors for additional traits and individual-level data, but haven't heard back, so merging in data that are available in the manuscript
---------

Co-authored-by: yangsophieee <[email protected]>
* old study and data extracted from tables and figures in paper
---------

Co-authored-by: yangsophieee <[email protected]>
* add new study
* data transcribed from manuscript & author not contacted

---------

Co-authored-by: yangsophieee <[email protected]>
* Add new study: Britton_1994
* First study with recruitment_time
* transcribed data from manuscript; no contact with author
---------

Co-authored-by: yangsophieee <[email protected]>
* Add new study: Cowling_1987
* data on germination & flowering relative to fire for 4 WA Banksia species
* data transcribed from manuscript; no contact with author

---------

Co-authored-by: yangsophieee <[email protected]>
* Add new study: Auld_2000
* dataset with seedbank longevity half-lives
---------

Co-authored-by: yangsophieee <[email protected]>
* edit metadata_create_template to add proper fields for data_collectors
* Tweak and add tests

---------

Co-authored-by: Daniel Falster <[email protected]>
* Add new study: Tsakalos_2022
* large dataset documenting clonal spread mechanisms and bud bank locations for WA taxa
* dataset available online, but will contact author
---------

Co-authored-by: yangsophieee <[email protected]>
@yangsophieee yangsophieee requested a review from ehwenk June 7, 2023 06:11
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a311f6c) 80.20% compared to head (1a0b1b5) 80.20%.

❗ Current head 1a0b1b5 differs from pull request most recent head 3c2a64f. Consider uploading reports for the commit 3c2a64f to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #719   +/-   ##
========================================
  Coverage    80.20%   80.20%           
========================================
  Files            7        7           
  Lines         1531     1531           
========================================
  Hits          1228     1228           
  Misses         303      303           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

data/Li_2018/metadata.yml Outdated Show resolved Hide resolved
data/Li_2018/metadata.yml Outdated Show resolved Hide resolved
@ehwenk
Copy link
Collaborator

ehwenk commented Jun 7, 2023

  • Just checking that Ks is sapwood_specific_conductivity, not stem_specific_conductivity? From text: "Kfinal was normalized by the pressure gradient, sapwood area, and stem length to obtain initial and final xylem-specific hydraulic conductivity (Ks, kg m−1 s−1 MPa−1)."

yes, correct

@ehwenk
Copy link
Collaborator

ehwenk commented Jun 7, 2023

  • Do we have traits for Ψleaf at 50% of maximum stomatal conductance ("Early decline of stomatal conductance; proxy of Ψleaf at which stomata initiate closure") and 10% of maximum stomatal conductance ("Maximum water stress while still maintaining minimal photosynthesis; proxy of complete stomatal closure")?

We don't at this point, but there are several studies with this trait. I'll add it to the additional traits section at the bottom

@ehwenk
Copy link
Collaborator

ehwenk commented Jun 7, 2023

  • What about Cbranch ('Amount of releasable water of living cells as xylem tension increases') and VIGR ('Stem volume index growth rate, a surrogate of plant growth rate')?

So... it was just suggested to us that we add capacitance, and I have, but I'm now worried I have the wrong units (lots of options) because my units aren't what they have here. We don't have VIGR

@ehwenk
Copy link
Collaborator

ehwenk commented Jun 7, 2023

  • I'm a bit confused with the methods for Amax, it says "Leaf net carbon assimilation rate (An)... were measured by placing the leaf into a 2 × 3 cm cuvette supplied with saturating light (1,500 μmol m−2 s−1) and ambient CO2 concentration (420 μmol mol−1)." If it's ambient CO2 then that's not Amax right? But they say it was for An not Amax. In the section before it says the following but I'm not sure what it means: "During this phase, leaf gas exchange characteristics and corresponding leaf water potential (Ψleaf, MPa) were measured periodically until positive net photosynthesis (Amax, μmol m−2 s−1) was no longer detectable."

I think there are two tricky bits here - it is Asat, not Amax - I'm surprised they call it Amax. Also, if you look at Table 2, they define it as "Maximum carbon assimilation rate under well-watered conditions". So I think that is the mean value they provide.

small changes following review
Copy link
Collaborator

@ehwenk ehwenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've answered all your questions - and made most of the changes myself.

Just look at some of the replicates.

data/Li_2018/metadata.yml Outdated Show resolved Hide resolved
data/Li_2018/metadata.yml Outdated Show resolved Hide resolved
@yangsophieee
Copy link
Collaborator Author

So... it was just suggested to us that we add capacitance, and I have, but I'm now worried I have the wrong units (lots of options) because my units aren't what they have here.

Looking back at the methods: "Branch RWC (RWCbranch, %) at each measurement period was calculated and plotted against Psi stem. Cbranch was estimated as the slope of the second linear portion of the water release curve, expressed as DeltaRWC/DeltaPsi (RWC MPa-1)."

  • Since RWC is in % should the units be 100.g/g/MPa? And if the units don't match with the new trait, what do we do?

@yangsophieee
Copy link
Collaborator Author

Also I used ausflora to check taxonomic updates and I'm wondering if Acmena smithii needs an update to Syzygium smithii?

@ehwenk
Copy link
Collaborator

ehwenk commented Jun 8, 2023

That taxonomic change should be automatic - when I review studies I look at the reports and confirm that all taxa are aligned to species - if the name doesn't automatically update, this wouldn't happen

…`leaf_stomatal_conductance_per_area_at_Asat`
@yangsophieee
Copy link
Collaborator Author

I think there are two tricky bits here - it is Asat, not Amax - I'm surprised they call it Amax. Also, if you look at Table 2, they define it as "Maximum carbon assimilation rate under well-watered conditions". So I think that is the mean value they provide.

I've changed replicates to 4 because "Four individuals of each species were assigned to a well-watered treatment and were watered daily over the experimental period."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants