-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new study: Li_2018 #719
base: develop
Are you sure you want to change the base?
Conversation
* Adding 7 studies with morphological trait data extracted from 7 state and national floras: "SAH_2023", "WAH_2023_1", "WAH_2023_2", "ABRS_2023", "RBGV_2023", "NHNSW_2023", "NTH_2023" * 30 traits added * trait values mostly mapped to those developed in vocabulary workshops, but a few additional terms were needed, especially for traits like leaf_base for which we previously had very little data * branch also includes some preliminary work on fire response traits and edits to water use/hydraulics traits --------- Co-authored-by: David Coleman <https://github.com/dcol2804> Co-authored-by: Sophie Yang <[email protected]>
Add large dataset on fire response, seed longevity and reproductive maturity of most taxa in the Northern Territory Herbarium database, compiled from the literature and expert review. Lizzy emailed the report to the author but he's on leave so merging now! --------- Co-authored-by: ehwenk <[email protected]>
Add 3 new studies from Nadia Santini looking at water relations Contributor has submitted her raw data files and reviewed all reports --------- Co-authored-by: Sophie Yang <[email protected]>
Add study examining how resprouting and propagule persistence are associated with grassland and shrubland habitats and other environmental and biotic variables. Lizzy has emailed the author and we are awaiting a response. --------- Co-authored-by: ehwenk <[email protected]>
Add study with seed storage location and fire response data (both resprouting and seedling recruitment) at the plot level after experimental fire treatments. The study also investigated density changes after fire, which I have not mapped. --------- Co-authored-by: ehwenk <[email protected]>
* edits to traits related to fire response and plant regeneration following one of the AusTraits vocabulary workshops * major change is renaming all `fire_response` related traits to `resprouting_capacity` * removing several derived traits that can be recreated from other trait values; in the coming 6 months we will create some scripts showing how current data can be analysed * remap values for some traits in NSWFRD_2014 to capture more data --------- Co-authored-by: Sophie Yang <[email protected]>
* add new study: Mitchell_2008 * no contact with data collector * some problems with archived data - for instance Kl data are identical to Ks, so not used. --------- Co-authored-by: yangsophieee <[email protected]>
* add new study: Kocacinar_2003 * contacted authors for additional traits and individual-level data, but haven't heard back, so merging in data that are available in the manuscript --------- Co-authored-by: yangsophieee <[email protected]>
* old study and data extracted from tables and figures in paper --------- Co-authored-by: yangsophieee <[email protected]>
* add new study * data transcribed from manuscript & author not contacted --------- Co-authored-by: yangsophieee <[email protected]>
* Add new study: Britton_1994 * First study with recruitment_time * transcribed data from manuscript; no contact with author --------- Co-authored-by: yangsophieee <[email protected]>
* Add new study: Cowling_1987 * data on germination & flowering relative to fire for 4 WA Banksia species * data transcribed from manuscript; no contact with author --------- Co-authored-by: yangsophieee <[email protected]>
* Add new study: Auld_2000 * dataset with seedbank longevity half-lives --------- Co-authored-by: yangsophieee <[email protected]>
* edit metadata_create_template to add proper fields for data_collectors * Tweak and add tests --------- Co-authored-by: Daniel Falster <[email protected]>
* Add new study: Tsakalos_2022 * large dataset documenting clonal spread mechanisms and bud bank locations for WA taxa * dataset available online, but will contact author --------- Co-authored-by: yangsophieee <[email protected]>
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #719 +/- ##
========================================
Coverage 80.20% 80.20%
========================================
Files 7 7
Lines 1531 1531
========================================
Hits 1228 1228
Misses 303 303 ☔ View full report in Codecov by Sentry. |
yes, correct |
We don't at this point, but there are several studies with this trait. I'll add it to the additional traits section at the bottom |
So... it was just suggested to us that we add capacitance, and I have, but I'm now worried I have the wrong units (lots of options) because my units aren't what they have here. We don't have VIGR |
I think there are two tricky bits here - it is Asat, not Amax - I'm surprised they call it Amax. Also, if you look at Table 2, they define it as "Maximum carbon assimilation rate under well-watered conditions". So I think that is the mean value they provide. |
small changes following review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I've answered all your questions - and made most of the changes myself.
Just look at some of the replicates.
Looking back at the methods: "Branch RWC (RWCbranch, %) at each measurement period was calculated and plotted against Psi stem. Cbranch was estimated as the slope of the second linear portion of the water release curve, expressed as DeltaRWC/DeltaPsi (RWC MPa-1)."
|
Also I used |
That taxonomic change should be automatic - when I review studies I look at the reports and confirm that all taxa are aligned to species - if the name doesn't automatically update, this wouldn't happen |
…`leaf_stomatal_conductance_per_area_at_Asat`
I've changed replicates to 4 because "Four individuals of each species were assigned to a well-watered treatment and were watered daily over the experimental period." |
Study investigating variation in key hydraulic and carbon economy traits of 12 woody species in Australia across a broad climatic gradient, using a common garden approach.
Questions for review:
life_stage
is -- they grew plants from seed, seedlings were transplanted in 2016 and then grown and measured until maybe May 2017? So one or two years old. Is it just juvenile?water_potential_12percent_lost_conductivity
? I can only find 50 and 88.sapwood_specific_conductivity
, notstem_specific_conductivity
? From text: "Kfinal was normalized by the pressure gradient, sapwood area, and stem length to obtain initial and final xylem-specific hydraulic conductivity (Ks, kg m−1 s−1 MPa−1)."sapwood_specific_conductivity
tosapwood_specific_hydraulic_conductivity
be updated when merged or do we need to do that here?