108 make output messages optional #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
fontikar
reviewed
Apr 22, 2024
| @@ -149,29 +157,29 @@ align_taxa <- function(original_name, | |||
| # take unique values so each name only processed once | |||
| dplyr::filter(!duplicated(original_name)) | |||
|
|
|||
| if (all(taxa$tocheck$checked)) { | |||
| if (all(taxa$tocheck$checked)|all(is.na(taxa$tocheck$checked))) { | |||
| message(" - all taxa are already checked, yay!") | |||
| return(invisible(taxa$tocheck)) | |||
There was a problem hiding this comment.
Can we also have a progress bar for alignment please like the load_taxonomic_resources one? I think it will be useful for larger datasets.
There was a problem hiding this comment.
yes, but maybe needs to be part of #191 ? adding the progress bar before re-factoring might make re-factor more confusing
fontikar
reviewed
Apr 22, 2024
|
@wcornwell if you merge in |
Merge remote-tracking branch 'origin/develop' into 108-make-output-messages-optional # Conflicts: # DESCRIPTION
fontikar
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #108 and #194