Simplify ruff usage and tighten version constraint #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let ruff choose which files to look at. This can also be configured with pyproject.toml entries following the docs https://docs.astral.sh/ruff/configuration/
Currently the versioning scheme for ruff includes breaking changes on minor version updates and compatible changes with patch version updates. Linting tools are often used in CI as a first pass, and pulling in a new version with changes that find new issues can cause headaches. Pulling in breaking changes and updates should be done carefully with manual version bump.
woodruffw
approved these changes
May 2, 2024
TBH, I'd be okay with deleting the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change,
$(ALL_PY_SRCS)is only used in theeditMakefile target