Skip to content

rebase and address review comments

Sign in for the full log view
GitHub Actions / Trunk Check failed Nov 16, 2023 in 24s

Trunk Check

Checked 3 modified files
✖ 6 new issues (1 auto-fixable)

Details

To reproduce and test locally, run:
trunk check

Annotations

Check failure on line 27 in src/blight/actions/embed_commands.py

See this annotation in the file changed.

@github-actions github-actions / Trunk Check

mypy(no-untyped-def) 

[new] Function is missing a type annotation for one or more arguments

Check failure on line 45 in src/blight/actions/embed_commands.py

See this annotation in the file changed.

@github-actions github-actions / Trunk Check

mypy(var-annotated) 

[new] Need type annotation for "env" (hint: "env: Dict[<type>, <type>] = ...")

Check failure on line 89 in src/blight/actions/embed_commands.py

See this annotation in the file changed.

@github-actions github-actions / Trunk Check

mypy(note) 

[new] This violates the Liskov substitution principle. See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides

Check failure on line 89 in src/blight/actions/embed_commands.py

See this annotation in the file changed.

@github-actions github-actions / Trunk Check

mypy(override) 

[new] Argument 1 of "before_run" is incompatible with supertype "Action"; supertype defines the argument type as "Tool"

Check failure on line 99 in src/blight/actions/embed_commands.py

See this annotation in the file changed.

@github-actions github-actions / Trunk Check

mypy(arg-type) 

[new] Argument 1 to "flock_append" has incompatible type "str"; expected "PathLike[Any]"

Check failure on line 1 in src/blight/actions/embed_commands.py

See this annotation in the file changed.

@github-actions github-actions / Trunk Check

black 

Incorrect formatting, autoformat by running 'trunk fmt'
View more details on GitHub Actions