Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to merge extract_failure signal when representer is used #12

Closed
wants to merge 1 commit into from
Closed

Do not try to merge extract_failure signal when representer is used #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/trailblazer/operation/validate.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def self.Validate(skip_extract: false, name: "default", representer: false, key:
options = {task: activity, id: "contract.#{name}.validate", outputs: activity.outputs}

# Deviate End.extract_failure to the standard failure track as a default. This can be changed from the user side.
options = options.merge(Activity::DSL.Output(:extract_failure) => Activity::DSL.Track(:failure)) unless skip_extract
options = options.merge(Activity::DSL.Output(:extract_failure) => Activity::DSL.Track(:failure)) unless skip_extract || representer
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we add the extract step only unless skip_extract || representer so makes sense to have the same block here


options
end
Expand Down