Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to merge extract_failure signal when representer is used #12

Closed
wants to merge 1 commit into from

Conversation

emaglio
Copy link
Member

@emaglio emaglio commented Mar 19, 2019

This should close #9

We don't have many tests (any tests with representer) - should we merge this for now and add an issue to add those tests?

@emaglio emaglio self-assigned this Mar 19, 2019
@emaglio emaglio requested a review from apotonick March 19, 2019 03:40
@@ -22,7 +22,7 @@ def self.Validate(skip_extract: false, name: "default", representer: false, key:
options = {task: activity, id: "contract.#{name}.validate", outputs: activity.outputs}

# Deviate End.extract_failure to the standard failure track as a default. This can be changed from the user side.
options = options.merge(Activity::DSL.Output(:extract_failure) => Activity::DSL.Track(:failure)) unless skip_extract
options = options.merge(Activity::DSL.Output(:extract_failure) => Activity::DSL.Track(:failure)) unless skip_extract || representer
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we add the extract step only unless skip_extract || representer so makes sense to have the same block here

@emaglio
Copy link
Member Author

emaglio commented Mar 19, 2019

PR already there for this

@emaglio emaglio closed this Mar 19, 2019
@apotonick apotonick deleted the fix_bug_9 branch March 2, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug when using validate macro with representer arg
1 participant