-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use
compare_by_identity
hash for the map
in Circuit
. This fixes…
… a bug that appeared with newer Ruby versions where people would use `GC.verify_compaction_references` to optimize memory consumption. After using the compaction, the circuit map would be corrupted when a task was a `Method` reference, leading to the following exception. NoMethodError: undefined method `[]' for nil /home/nick/projects/trailblazer-activity/lib/trailblazer/activity/circuit.rb:80:in `next_for' thanks to @tiagotex for deep-diving into Ruby to find where this originates from and also providing a simple solution. :wine:
- Loading branch information
Showing
2 changed files
with
39 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters