feat: badge cleanup #221
Merged
feat: badge cleanup #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seedy
commented
Dec 6, 2021
| variant: 'orange', | ||
| css: { '&:focus-visible': { boxShadow: '0 0 0 1px $colors$orange9' } }, | ||
| }, | ||
| { |
There was a problem hiding this comment.
ℹ️ missing compoundVariant purple
seedy
commented
Dec 6, 2021
| </Badge> | ||
| <Badge as="button" {...args} variant="orange"> | ||
| Orange | ||
| </Badge> |
There was a problem hiding this comment.
ℹ️ missing purple in story
seedy
commented
Dec 6, 2021
| </Badge> | ||
| <Badge {...args} variant="orange"> | ||
| Orange | ||
| </Badge> |
There was a problem hiding this comment.
ℹ️ missing purple in story
seedy
commented
Dec 10, 2021
| @@ -69,7 +69,7 @@ | |||
| "react": "17.0.1", | |||
| "react-dom": "17.0.1", | |||
| "rollup": "^2.33.1", | |||
| "rollup-plugin-typescript2": "^0.29.0", | |||
| "rollup-plugin-typescript2": "^0.30.0", | |||
There was a problem hiding this comment.
ℹ️ Check PR description
added 5 commits
December 10, 2021 19:04
traefiker
force-pushed
the
feat/badge-cleanup
branch
from
0e73a88 to
0aac6e3
Compare
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleaning up badge component, NB: this applies no design system changes.
This will be done, hopefully in a future step.
gray) is duplicated to make sure it's clear to the userPackage changes
rollup-plugin-typescript2from^0.29.0to^0.30.0due to a build issueError: '__spreadArrays' is not exported by tsliboccurs whennpm run buildalexjoverm/typescript-library-starter#310 (comment)