-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/tensor basic ops #2468
Docs/tensor basic ops #2468
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2468 +/- ##
==========================================
+ Coverage 82.79% 82.93% +0.13%
==========================================
Files 809 811 +2
Lines 104191 105059 +868
==========================================
+ Hits 86270 87135 +865
- Misses 17921 17924 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on the examples 🙏
Just a few comments to get this started:
- Make sure to run the tests for formatting and ensure the doc examples can compile (see CI errors)
- I see some methods have more than one example. I think we should keep the examples succinct, so stick to one
example()
definition (though you could still demonstrate different manipulations when deemed relevant)
@laggui made the necessary changes, as well as a fix for the failing doc examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Made some minor changes mostly for formatting.
Pull Request Template
Checklist
run-checks all
script has been executed.Related Issues/PRs
#2450
Provide links to relevant issues and dependent PRs.
Changes
Tensor BasicOps Examples