-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added maxpool1d onnx operator #1725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1725 +/- ##
==========================================
+ Coverage 86.47% 86.52% +0.05%
==========================================
Files 698 699 +1
Lines 82874 83057 +183
==========================================
+ Hits 71667 71867 +200
+ Misses 11207 11190 -17 ☔ View full report in Codecov by Sentry. |
@antimora fixed. The flake being commited was an issue on my end ( I am using nixos and need to specify the dependencies required to build the project for reproducibility ). Force pushed so that these files don't appear in the commit history of the repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for your contribution!
Pull Request Template
Checklist
run-checks all
script has been executed.Related Issues/PRs
#1714
Changes
Summarize the problem being addressed and your solution.
Testing
Describe how these changes have been tested.