Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added maxpool1d onnx operator #1725

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

Arjun31415
Copy link
Contributor

@Arjun31415 Arjun31415 commented May 5, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

#1714

Changes

Summarize the problem being addressed and your solution.

Testing

Describe how these changes have been tested.

Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your help adding ONNX ops. Overall, it looks perfect with minor required changes. One unit test is failing and I commented on it. Here is the failed test:

image

crates/burn-import/src/burn/node/max_pool1d.rs Outdated Show resolved Hide resolved
flake.lock Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 99.43820% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.52%. Comparing base (152509c) to head (7658d55).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/burn-core/src/nn/pool/max_pool1d.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1725      +/-   ##
==========================================
+ Coverage   86.47%   86.52%   +0.05%     
==========================================
  Files         698      699       +1     
  Lines       82874    83057     +183     
==========================================
+ Hits        71667    71867     +200     
+ Misses      11207    11190      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Arjun31415 Arjun31415 requested a review from antimora May 6, 2024 05:34
@Arjun31415
Copy link
Contributor Author

Arjun31415 commented May 6, 2024

@antimora fixed. The flake being commited was an issue on my end ( I am using nixos and need to specify the dependencies required to build the project for reproducibility ). Force pushed so that these files don't appear in the commit history of the repo

Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for your contribution!

@antimora antimora merged commit 7f94f4c into tracel-ai:main May 6, 2024
14 checks passed
@Arjun31415 Arjun31415 deleted the onnx-maxpool branch May 6, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants