Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reshape bug (support for opset version 1) #1667

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

antimora
Copy link
Collaborator

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

#1593

Changes

  1. Use shape attribute

Testing

Pytorch supports opset 7+ so I could not recreate the ONNX file but I was able to use the onnx from #1593

@antimora antimora requested a review from laggui April 19, 2024 22:43
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 79.16667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 86.41%. Comparing base (6c70852) to head (2551635).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/burn-import/src/onnx/dim_inference.rs 79.16% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1667   +/-   ##
=======================================
  Coverage   86.41%   86.41%           
=======================================
  Files         694      694           
  Lines       80676    80666   -10     
=======================================
- Hits        69718    69710    -8     
+ Misses      10958    10956    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments on form, otherwise LGTM! Approving in advance.

crates/burn-import/src/onnx/dim_inference.rs Outdated Show resolved Hide resolved
crates/burn-import/src/onnx/dim_inference.rs Outdated Show resolved Hide resolved
@antimora antimora merged commit 1718da5 into tracel-ai:main Apr 22, 2024
14 checks passed
@antimora antimora mentioned this pull request Apr 23, 2024
2 tasks
syl20bnr pushed a commit that referenced this pull request Apr 26, 2024
* Make reshape op version 1

* Refactor per PR feedback
@antimora antimora deleted the reshape-bug-fix branch April 29, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants