Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more functionalities and some eye candies #8

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

EffEPi
Copy link

@EffEPi EffEPi commented Mar 17, 2016

I made some changes that will allow the change in time not to affect the tickets as well as the visualization of the "worked" tickets.

Plus I also added some functionality like:

  • display 30, 60, 120, 365 days (30 default)
  • the legend is outside the graph
  • ability to stack the graph
  • clicking on a label on the legend will hide that part of the graph
  • fixed the open tickets to be based on the end of the day for that day and not on the next day

setup.py Outdated
@@ -8,10 +8,10 @@
packages = ['ticketgraph'],
package_data = { 'ticketgraph' : [ 'htdocs/*.*', 'templates/*.*' ] },

author = 'Colin Snover',
author_email = '[email protected]',
author = 'Fabrizio Parrella',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing authorship information like this is not appropriate.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I initially meant to create a new plugin all together that is why I did change it. reverting that change

@csnover
Copy link
Member

csnover commented Mar 23, 2016

Please don’t use one commit per file. Use one commit per feature.

@csnover
Copy link
Member

csnover commented Mar 23, 2016

There are a lot of issues with this PR, it cannot be accepted as-is. Please try again.

@EffEPi
Copy link
Author

EffEPi commented Mar 23, 2016

sorry for the many commits. new to GitHub and I am using the website to push code for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants