Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduced fullscreen and added decorated for Gtk4 #18

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WebReflection
Copy link
Contributor

@WebReflection WebReflection commented Oct 4, 2024

This MR exports two extra symbols to remove decorations (chromeless) and to provide an easy way to make the window full screen.

A new SizeHint.FULLSCREEN can be used to provide such hint while the Size now has a decorated value which, if false, would remove all decorations around the UI.

Related webview changes WebReflection/webview#1

Published on npm as @webreflection/webview-bun

@WebReflection
Copy link
Contributor Author

FYI I have no intention to merge this into your project ... I just want to understand a few things and I will publish under my namespace once I've built the same for arm64.

The main things that won't likely land around are:

  • it's only Gtk4 as I don't care/need anything else for the fullscreen story at this point
  • it's changing a bit a few things around and I don't have strong opinions about those changes so happy to do those in a different way, still I need fullscreen already so this will be my fork that provides such utility for both x64 and arm64

This MR exports two extra symbols to remove decorations (chromeless)
and to provide an easy way to make the window full screen.

A new `SizeHint.FULLSCREEN` can be used to provide such hint
while the `Size` now has a `decorated` value which, if `false`,
would remove all decorations around the UI.
@WebReflection WebReflection force-pushed the gtk4-fullscreen-decorated branch from df76ab9 to faf50f9 Compare October 4, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant