Revert "treewide: disable text LVGL text scrolling" #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Scrolling is great, but I've connected ChatGPT to my Willow, so sometimes the responses are fairly long. Would it be possible to have the text scroll upwards if the response is above a certain length, to enable that use case? |
|
I would first like to test the impact of re-enabling our original scrolling before we introduce more complex scrolling. If we get display lockups again with this, we will probably give up on scrolling entirely, as we're an audio device first and stability is infinitely more important than the display UI. |
kristiankielhofner
approved these changes
Sep 5, 2023
We previously disabled LVGL text scrolling to test if this would fix the display locking up, but we kept experiencing the lockups. We believe commit c8561a1 ("sdkconfig: enable LCD_RGB_ISR_IRAM_SAFE") finally fixed the problem. We do not want to risk this causing problems in the 0.1.0 release again, but now that we've branched release/v0.1, let's enable text scrolling again in main. This reverts commit 5b46dbd.
kristiankielhofner
force-pushed
the
feature/lvgl_text_scrolling
branch
from
7e21bc0
to
9a82037
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously disabled LVGL text scrolling to test if this would fix the display locking up, but we kept experiencing the lockups. We believe commit c8561a1 ("sdkconfig: enable LCD_RGB_ISR_IRAM_SAFE") finally fixed the problem.
We do not want to risk this causing problems in the 0.1.0 release again, but now that we've branched release/v0.1, let's enable text scrolling again in main.
This reverts commit 5b46dbd.