CI improvements #242
Merged
CI improvements #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github Actions does not support adding dependencies between multiple workflows. For this reason, we previously defined all CI actions in a single workflow file. As we really don't like this approach, here is another attempt to improve the situation. We now have a meta workflow, that will call other workflows based on the changed files. If any file is being changed that would result in a changed build container, we call the build_container workflow. The build_container workflow calls the build_willow workflow once it's done. If the changed files would not result in a changed build container, we directly call the build_willow workflow. This will make the CI more efficient, and faster in case we don't change any files that would result in a changed build container. It will also work around the limitation of Github Actions that prevent us from publishing container images to GHCR for PRs openend from forks. This will still be a problem when people want to submit changes to the build container, but we're still investigating options how to fix this properly.
Since cbd03e3 ("utils.sh: use willow branch from our ESP-ADF fork") we no longer need to apply patches when preparing the build container. Drop the patches directory as it is no longer used since that commit.
There is no point in running a Willow build when there aren't any changes to source files, or other files included in the Willow images.
kristiankielhofner
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages.
Corresponding runs in test repo:
https://github.com/toverainc/willow-test/actions/runs/5904530365
https://github.com/toverainc/willow-test/actions/runs/5904916189