Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

... #7

Merged
merged 1 commit into from
Sep 13, 2023
Merged

... #7

merged 1 commit into from
Sep 13, 2023

Conversation

tot-ra
Copy link
Owner

@tot-ra tot-ra commented Sep 13, 2023

No description provided.

@github-actions
Copy link

File: "index.js",
Line: 31,
Comment: Please check environment variables for PR_NUMBER. The code fails at this line if these are not declared correctly.

File: "index.js",
Line: 38,
Comment: The data returned from the graphql query should be error-handled. It might fail and return undefined and would lead to a crash on the next line.

File: "README.md",
Line: 15,
Comment: In the "Example usage" code, the secret variables mentioned should be configured properly in Github secrets for the action to work correctly.

File: "action.yml",
Line: 24,
Comment: For the "check" step in the action YAML file, make sure that node_modules are properly installed and both required packages and dist/index.js file exist before the step is executed.

File: "package.json",
Line: 13,
Comment: The "main" property is pointing to an "index.js" file, but in the build step at Line: 14, it mentions that the built file is in "licenses.txt". This might be a mistake; if "licenses.txt" is the built output, then the "main" property should point to "licenses.txt", else the build command should output "index.js". Please correct this.

File: "package-lock.json",
Line: 1,
Comment: The "package-lock.json" should not be manually updated or resolved if there were any conflicts. Please use the command line/npm install to generate these changes.

Please consider these changes and review accordingly.

@tot-ra tot-ra merged commit 5f32b29 into main Sep 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant