Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for curve ed25519 #7

Merged
merged 6 commits into from
Apr 16, 2024
Merged

Add support for curve ed25519 #7

merged 6 commits into from
Apr 16, 2024

Conversation

matthiasgeihs
Copy link
Member

This adds support for ed25519 curve.

@matthiasgeihs matthiasgeihs force-pushed the feat/ed25519 branch 2 times, most recently from bae34fe to c790f35 Compare February 24, 2023 11:01
@matthiasgeihs matthiasgeihs marked this pull request as ready for review January 24, 2024 18:03
@matthiasgeihs
Copy link
Member Author

Need to bump version? @himanshuchawla009

@himanshuchawla009
Copy link
Member

Need to bump version? @himanshuchawla009

i will bump it during release, it doesnt seems to have any breaking versions right, all apis and response types are backward compatible?

@matthiasgeihs
Copy link
Member Author

matthiasgeihs commented Apr 15, 2024

Need to bump version? @himanshuchawla009

i will bump it during release, it doesnt seems to have any breaking versions right, all apis and response types are backward compatible?

Technically, there are some breaking changes:

  1. The client now expects a keyType parameter upon initialization.
  2. The client will now send a key_type parameter with every request to the server.

(1.) could be made non-breaking by using secp256k1 as default if not keyType is provided.
(2.) may be breaking or may not be depending on how the server handles unknown parameters: does it throw? or just ignore?

@himanshuchawla009
Copy link
Member

Need to bump version? @himanshuchawla009

i will bump it during release, it doesnt seems to have any breaking versions right, all apis and response types are backward compatible?

Technically, there are some breaking changes:

1. The client now expects a `keyType` parameter upon initialization.

2. The client will now send a `key_type` parameter with every request to the server.

(1.) could be made non-breaking by using secp256k1 as default if not keyType is provided. (2.) may be breaking or may not be depending on how the server handles unknown parameters: does it throw? or just ignore?

Just tested, server doesn't throws currently on passing unknown params.

@matthiasgeihs
Copy link
Member Author

So does this PR look good? Or you want me to change anything? @himanshuchawla009

@matthiasgeihs matthiasgeihs changed the base branch from main to alpha April 16, 2024 08:40
@matthiasgeihs
Copy link
Member Author

@himanshuchawla009, have created alpha branch and targeted that one here. Please merge and publish when you are ready. Also, could you please set alpha branch as default?

@himanshuchawla009 himanshuchawla009 merged commit 8864b33 into alpha Apr 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants