-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing space in ru translation #245
Conversation
@zerolab can you help with ruff checks? |
@ACK1D yeah. it is on my list to update https://github.com/torchbox/wagtailmedia/blob/main/.github/workflows/ruff.yml#L18 to install the same version defined in https://github.com/torchbox/wagtailmedia/blob/main/.pre-commit-config.yaml#L21 and add comments to both to keep them in sync |
@zerolab checked on version 0.2.0, no problems. But the checks do not pass. That's weird. |
the ruff check currently installs the latest ruff version, hence the failure. the test failures are separate, though |
commit 718151a includes fixes for which ruff 0.5.4 was "swearing". I don't know if this is necessary. I just wanted to correct a line in the translation) |
Co-authored-by: Dan Braghiș <[email protected]>
diff --git a/.github/workflows/ruff.yml b/.github/workflows/ruff.yml
index 0e6a867..a6901ab 100644
--- a/.github/workflows/ruff.yml
+++ b/.github/workflows/ruff.yml
@@ -15,8 +15,8 @@ jobs:
steps:
- uses: actions/checkout@v4
- - run: python -Im pip install --user ruff
+ - run: python -Im pip install --user ruff==0.5.4
- name: Run ruff
working-directory: ./src
- run: ruff --output-format=github wagtailmedia
+ run: ruff check --output-format=github wagtailmedia
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index b019d1d..2ce2e10 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -18,7 +18,7 @@ repos:
- id: end-of-file-fixer
- id: trailing-whitespace
- repo: https://github.com/astral-sh/ruff-pre-commit
- rev: 'v0.2.0'
+ rev: 'v0.5.4'
hooks:
- id: ruff
args: [--fix, --exit-non-zero-on-fix] here's a patch to take this over the line |
@zerolab well done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
No description provided.