Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding the edit form action #229

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

davidwtbuxton
Copy link
Contributor

This makes it the same as the add form. Useful if you are doing something weird using Google's blobstore.create_upload_url(..) API.

@davidwtbuxton davidwtbuxton marked this pull request as ready for review November 14, 2023 14:17
@zerolab
Copy link
Member

zerolab commented Nov 14, 2023

This makes it the same as the add form. Useful if you are doing
something weird using Google's blobstore.create_upload_url(..) API.
@davidwtbuxton
Copy link
Contributor Author

Thanks for the pointer to the existing tests. I've updated this patch.

@davidwtbuxton
Copy link
Contributor Author

Hi @zerolab I've added a test for the Django template, OK to merge?

Copy link
Member

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Thanks @davidwtbuxton

@zerolab zerolab merged commit f3fd3f0 into torchbox:main Dec 1, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants