Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci.yml: Upgrade GitHub Actions #237

Merged
merged 1 commit into from
Jan 9, 2024
Merged

ci.yml: Upgrade GitHub Actions #237

merged 1 commit into from
Jan 9, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 5, 2024 •
edited
Loading

Let's get the GitHub Actions passing again.

Description

Please include a summary of the changes and which issue this relates to (if applicable).

Fixes # (issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

zerolab
zerolab requested changes Jan 5, 2024
View reviewed changes
Copy link
Member

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start, thank you @cclauss.
Needs a bit more work

.github/workflows/ci.yml Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@cclauss cclauss requested a review from zerolab January 5, 2024 13:30
zerolab
zerolab reviewed Jan 5, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@cclauss cclauss requested a review from zerolab January 5, 2024 18:15
zerolab
zerolab approved these changes Jan 6, 2024
View reviewed changes
Copy link
Member

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zerolab zerolab merged commit dfc31df into torchbox:main Jan 9, 2024
10 checks passed
@cclauss cclauss deleted the patch-1 branch January 9, 2024 12:32
@cclauss cclauss mentioned this pull request Jan 9, 2024
Closed
CuriousLearner added a commit to lincolnloop/django-pattern-library that referenced this pull request Feb 24, 2024
@CuriousLearner
Merge branch 'main' of https://github.com/torchbox/django-pattern-lib…
6810527 
…rary into jinja

* 'main' of https://github.com/torchbox/django-pattern-library:
  Add Python 3.12 to the test matrix, drop Django 4.1 (torchbox#242)
  Updates for version 1.2.0
  Improve handling of non-string values for 'override_tag's 'default_html' argument (torchbox#224)
  fix: make it work for django5.0 (updated) (torchbox#241)
  Upgrade GitHub Actions versions (torchbox#237)
  Fix typos discovered by codespell (torchbox#238)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerolab zerolab zerolab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @zerolab