Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yq parsing for version 4.x #16

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Fix yq parsing for version 4.x #16

merged 1 commit into from
Nov 19, 2024

Conversation

brablc
Copy link
Contributor

@brablc brablc commented Nov 18, 2024

Apparently the depracation warning about -j does not get ignored, but mixed to the output. We have to use vim.system instead (Neovim 0.9+).

Apparently the depracation warning about `-j` does not get ignored, but
mixed to the output. We have to use `vim.system` instead (Neovim 0.9+).
@topaxi
Copy link
Owner

topaxi commented Nov 19, 2024

Works on my machine, arch and yq 3.4.3.

Happy to merge once you feel this is ready.

@brablc
Copy link
Contributor Author

brablc commented Nov 19, 2024

Tested with Ubuntu 3.1 and works!

@brablc brablc marked this pull request as ready for review November 19, 2024 08:30
@topaxi topaxi merged commit 07964ce into topaxi:main Nov 19, 2024
2 checks passed
@topaxi
Copy link
Owner

topaxi commented Nov 19, 2024

Amazing, thank you for your time and effort! 😊

@brablc
Copy link
Contributor Author

brablc commented Nov 19, 2024

I thank you for this amazing tool. I was very surprised, that I did not find any similar plugin for gh cli, then again surprised that it is not covered by lazygit, and then I was finaly happy to find it for neovim. And I already learned before, that with lua and neovim things sometimes break but it is possible to fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants