-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted to Androidx and made this library live again #656
base: v3.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm except hardcoded versions
api project(':fetch2core') | ||
|
||
testImplementation "junit:junit:$junit_version" | ||
androidTestImplementation "com.android.support.test:runner:$test_runner_version" | ||
androidTestImplementation "com.android.support.test.espresso:espresso-core:$espresso_version" | ||
androidTestImplementation 'androidx.test.ext:junit:1.1.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably better to stay with constants instead of hardcoded versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the diff here?
This project converted to Androidx and can be publish through jitpack.io