Migrate off of gogo/protobuf #171
Conversation
kzys
force-pushed
the
bye-gogo
branch
3 times, most recently
from
8eb80ca to
e49ae8a
Compare
clone.go
Outdated
| clone := proto.Clone(from) | ||
| typed, ok := clone.(T) | ||
| if !ok { | ||
| return zero, fmt.Errorf("failed to cast %+v to %+v", clone, zero) |
There was a problem hiding this comment.
only pkg/errors allowed in these repos
There was a problem hiding this comment.
I didn't know that. Will fix.
clone.go
Outdated
|
|
||
| func cloneProto[T protoreflect.ProtoMessage](from T) (T, error) { | ||
| var zero T | ||
| clone := proto.Clone(from) |
There was a problem hiding this comment.
I'm a bit worried about including this reflect-based clone in this internal logic where no reflect should be needed. Are there other options?
There was a problem hiding this comment.
Eg. maybe some of these private functions should not use proto based types.
There was a problem hiding this comment.
Ended up just doing the below.
clone := &types.Stat{
Path: from.Path,
Mode: from.Mode,
Uid: from.Uid,
...
}
|
I triggered CI; looks like there's a small linting failure; |
gogo/protobuf has been deprecated since 2022. This change uses Google's code generator instead of gogo/protobuf. Signed-off-by: Kazuyoshi Kato <[email protected]>
|
@thaJeztah Thanks! Fixed. |
|
Awesome; I kicked it again, and it's green now 👍 (I'm not super-familiar with this code, so I'll leave actual review to @tonistiigi, but noticed the PR, and saw CI needed approval 😅) |
This reverts commit d22c3fa, reversing changes made to f098008. Signed-off-by: CrazyMax <[email protected]>
gogo/protobuf has been deprecated since 2022. This change uses Google's code generator instead of gogo/protobuf.