-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Author.email field and merge authors by name #10
base: master
Are you sure you want to change the base?
Conversation
For example "John Smith <[email protected]>" and "John Smith <[email protected]>" are considered as a single author regardless of the different email addresses. This change is just a workaround. But as the URL for author details is constructed from Autor.dirname (as opposed to Author.email - see dc4d2a0) the original version does not work anyway. This seems to me as a suitable quickfix until the whole issue is properly addressed.
+1 |
Thanks for pointing the problem with author details URL. I think better solution than removing email field from author would be to:
|
Hello Tomasz, |
Ping for this - CLI-wise, I agree that a toggle to allow the operator to turn off the email behavior is a good idea. |
For example
John Smith <[email protected]>
andJohn Smith <[email protected]>
are considered as a single authorJohn Smith
regardless of the different email addresses.As the URL for author details is constructed from
Autor.dirname
(as opposed toAuthor.email
- see dc4d2a0) the original version does not work properly.This change is just a workaround and is not intended for a direct merge, I created it just to trigger a discussion.
However, for me personally it feels as a suitable quickfix until the whole issue is properly addressed.