Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CountryFlagFinder #2595

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

YogeshBabyOP
Copy link

All 5 Tasks Done ✅✅

  1. Localized using Tolgee@react
  2. Made an web page using react and storing one demos/
  3. The production of this pr : https://tolgee-flag-finder.vercel.app/

4.Added an article on dev.to https://dev.to/yogeshbabyop/building-a-multilingual-country-finder-app-with-tolgee-and-react-1nf9

image
5. Stared ⭐✨

Localized using Tolgee@react
Copy link
Contributor

@JanCizmar JanCizmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks a lot for the demo 🎉

  • The language select doesn't have proper emojis
  • The language select doesn't change when item is selected

Other then that it's ready to go!

@JanCizmar
Copy link
Contributor

Hey! Any updates to this?

@YogeshBabyOP
Copy link
Author

Hi @JanCizmar
sorry for the delay, here is the updated url

https://tolgee-flag-finder.netlify.app/

@YogeshBabyOP
Copy link
Author

YogeshBabyOP commented Oct 27, 2024

Hii @JanCizmar
can you please review the changes

@JanCizmar JanCizmar self-requested a review October 29, 2024 19:15
@JanCizmar
Copy link
Contributor

Hey! Have you comitted the latest changes? I cannot see the emojis fixed in the code.

@JanCizmar
Copy link
Contributor

JanCizmar commented Oct 29, 2024

Also, I cannot se the exported jsons in your app, so it's not ready for being build for production.

EDIT: Oh, you are using the CDN. Then it's OK.

@YogeshBabyOP
Copy link
Author

Hi @JanCizmar
is this pr ready to merge?

@JanCizmar
Copy link
Contributor

When using the live demo, the language doesn't change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants