Merge pull request #1078 from yilmazbekdemir/prevent-role-organizatio…

…n-admin-on-workflowteam

Make unable to create workflowteam with OrgAdmin role

workflow/models.py

@@ -723,6 +723,12 @@ class Meta:
         verbose_name = "Workflow Team"
         verbose_name_plural = "Workflow Teams"
 
+    def clean(self):
+        if self.role and self.role.name == ROLE_ORGANIZATION_ADMIN:
+            raise ValidationError(
+                'Workflowteam role can not be ROLE_ORGANIZATION_ADMIN'
+            )
+
     def save(self, *args, **kwargs):
         if self.create_date == None:
             self.create_date = timezone.now()

workflow/signals.py

@@ -87,6 +87,7 @@ def check_seats_save_team(sender, instance, **kwargs):
     Validate, increase or decrease the amount of used seats
     based on the roles
     """
+    instance.full_clean()
     if os.getenv('APP_BRANCH') == DEMO_BRANCH:
         return
 

workflow/tests/test_models.py

@@ -3,7 +3,7 @@
 from django.test import TestCase, override_settings, tag
 
 import factories
-from workflow.models import TolaUser, Office
+from workflow.models import TolaUser, Office, ROLE_ORGANIZATION_ADMIN
 
 
 @tag('pkg')
@@ -55,6 +55,13 @@ def test_print_instance(self):
                          (u'Thom Yorke - ProgramAdmin <Health and Survival '
                           u'for Syrians in Affected Regions>'))
 
+    def test_save_role_org_admin_fails(self):
+        wfteam = factories.WorkflowTeam.build(
+            role=factories.Group(name=ROLE_ORGANIZATION_ADMIN),
+            workflow_user=factories.TolaUser(),
+            workflowlevel1=factories.WorkflowLevel1())
+        self.assertRaises(ValidationError, wfteam.save)
+
 
 @tag('pkg')
 class ProductTest(TestCase):