Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): desktop multiple server support #8979

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Dec 2, 2024

No description provided.

Copy link

graphite-app bot commented Dec 2, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added mod:infra Environment related issues and discussions mod:i18n Related to i18n mod:env mod:component app:electron Related to electron app mod:store app:server test Related to test cases app:core labels Dec 2, 2024
Copy link
Member Author

EYHN commented Dec 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 25.49020% with 76 lines in your changes missing coverage. Please review.

Project coverage is 65.21%. Comparing base (af81c95) to head (8963826).
Report is 2 commits behind head on canary.

Files with missing lines Patch % Lines
...rontend/core/src/modules/cloud/services/servers.ts 0.00% 19 Missing ⚠️
...rontend/core/src/modules/cloud/services/captcha.ts 0.00% 10 Missing ⚠️
...ore/src/modules/desktop-api/service/desktop-api.ts 0.00% 8 Missing ⚠️
...ommon/infra/src/modules/workspace/entities/list.ts 28.57% 5 Missing ⚠️
...ackages/backend/server/src/core/auth/controller.ts 20.00% 4 Missing ⚠️
packages/common/infra/src/framework/core/event.ts 55.55% 4 Missing ⚠️
packages/frontend/track/src/mixpanel.ts 0.00% 4 Missing ⚠️
...ges/frontend/core/src/modules/cloud/stores/auth.ts 0.00% 3 Missing ⚠️
...nd/core/src/modules/cloud/stores/cloud-doc-meta.ts 0.00% 3 Missing ⚠️
...end/core/src/modules/cloud/stores/server-config.ts 0.00% 3 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8979      +/-   ##
==========================================
+ Coverage   64.72%   65.21%   +0.48%     
==========================================
  Files         664      669       +5     
  Lines       37349    37408      +59     
  Branches     3614     3656      +42     
==========================================
+ Hits        24176    24394     +218     
+ Misses      12805    12664     -141     
+ Partials      368      350      -18     
Flag Coverage Δ
server-test 77.83% <20.00%> (+0.69%) ⬆️
unittest 34.45% <25.77%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

nx-cloud bot commented Dec 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8963826. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@EYHN EYHN force-pushed the eyhn/feat/multiple-server-server branch from 8f73f31 to 8963826 Compare December 3, 2024 05:51
@graphite-app graphite-app bot merged commit 8963826 into canary Dec 3, 2024
46 checks passed
@graphite-app graphite-app bot deleted the eyhn/feat/multiple-server-server branch December 3, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app app:server mod:component mod:env mod:i18n Related to i18n mod:infra Environment related issues and discussions mod:store test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants