Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): peek db row should always show the related db row property #8942

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Nov 27, 2024

fix BS-1963
depends on toeverything/blocksuite#8818

Copy link

graphite-app bot commented Nov 27, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added mod:i18n Related to i18n app:core labels Nov 27, 2024
Copy link
Collaborator Author

pengx17 commented Nov 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pengx17 pengx17 marked this pull request as ready for review November 27, 2024 08:48
@pengx17 pengx17 changed the title fix(core): should always be able to show the referred database row when opening via center peek a database row fix(core): peek db row should always show the related db row property Nov 27, 2024
Copy link

nx-cloud bot commented Nov 27, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 02da873. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.77%. Comparing base (6e25243) to head (02da873).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8942      +/-   ##
==========================================
- Coverage   64.77%   64.77%   -0.01%     
==========================================
  Files         665      665              
  Lines       37373    37373              
  Branches     3608     3608              
==========================================
- Hits        24210    24208       -2     
- Misses      12796    12798       +2     
  Partials      367      367              
Flag Coverage Δ
server-test 77.13% <ø> (ø)
unittest 34.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant