Notes: narrow to the complete template instead of last org-heading #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, a note template consisting of sub-headings would result in only showing that sub-heading, e.g. using a template like this: * Author (XXX): Title ** takeaways ** new questions ** additional literature would only narrow to additional literature. Now we narrow to the complete template instead. A side-effect is that for non-org templates the point is now at the start of the template instead of the end.
|
I thought about point positioning and would actually prefer if the point was always at the start but didn't want to also change that in this PR. |
|
Thank you for this PR. Makes perfect sense. However, there is another PR (#263) in which we switch to org-capture as the underlying infrastructure. I think this will also allow us to specify in the template where the cursor should be placed. And correct narrowing should come for free if I'm not mistaken. |
|
Yes, I saw that PR, but also that its last activity was in October. This is just a minimal bugfix. |
|
Merged, thank you! (And neat idea to have predefined subsections.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, a note template consisting of sub-headings would result in
only showing that sub-heading, e.g. using a template like this:
** takeaways
** new questions
** additional literature
would only narrow to additional literature. Now we narrow to the
complete template instead.
A side-effect is that for non-org templates the point is now at the
start of the template instead of the end.