Apply suggestions from code review

Co-authored-by: Mateusz Jakub Fila <[email protected]>
tmadlener · Sep 16, 2024 · 6f68c09 · 6f68c09
1 parent 5ee96af
commit 6f68c09
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/scripts/createEDM4hepFile.py b/scripts/createEDM4hepFile.py
@@ -36,7 +36,7 @@ def create_MCParticleCollection():
     counter = count(COUNT_START)
     particles = edm4hep.MCParticleCollection()
     p_list = []
-    for i in range(3):
+    for _ in range(3):
         particle = particles.create()
         p_list.append(particle)
         particle.setPDG(next(counter))

diff --git a/test/test_EDM4hepFile.py b/test/test_EDM4hepFile.py
@@ -3,7 +3,6 @@
 created by scripts/createEDM4hepFile.py has the expected contents
 """
 
-import os
 import podio
 import edm4hep
 import pytest
@@ -12,7 +11,7 @@
 # For now simply copy these from createEDM4hepFile.py
 FRAMES = 3
 VECTORSIZE = 5
-COUNT_START = 42  # Where to the counter from
+COUNT_START = 42  # Starting point for the counters
 
 
 @pytest.fixture(scope="module")