Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track lazy loaded components #82

Merged
merged 7 commits into from
Jan 4, 2024

Conversation

haveyaseen
Copy link
Contributor

@haveyaseen haveyaseen commented Jan 2, 2024

Fixes #81

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
signia ✅ Ready (Inspect) Visit Preview Jan 3, 2024 5:33pm

@haveyaseen haveyaseen marked this pull request as ready for review January 2, 2024 20:41
Copy link
Contributor

@ds300 ds300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent work, thank you! Just one tiny change and I think we'll be good to go.

packages/signia-react/src/track.ts Outdated Show resolved Hide resolved
Co-authored-by: David Sheldrick <[email protected]>
@ds300 ds300 added the patch Increment the patch version when merged label Jan 4, 2024
@ds300 ds300 merged commit a28570e into tldraw:main Jan 4, 2024
2 of 4 checks passed
@ds300
Copy link
Contributor

ds300 commented Jan 4, 2024

just released in v0.1.5

@haveyaseen haveyaseen deleted the track-lazy-loaded-components branch January 4, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

signia-react-jsx doesn't work with lazy-loaded components in Vite/React
2 participants