Added support for all of the capture option classes to GrabzItBundle (#1

) * Added support for all of the capture option classes to GrabzItBundle * Documentation and Test Changes to support the other option classes
tlamedia · Jun 4, 2019 · 26f595e · 26f595e
1 parent 6ebea9e
commit 26f595e
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -39,7 +39,7 @@ tla_grabzit:
 
 ## Usage
 
-The bundle registers the services `tla_grabzit.options` and `tla_grabzit.client`, which allows you to use the GrabzIt API.
+The bundle registers the services `tla_grabzit.imageoptions`, `tla_grabzit.pdfoptions`, `tla_grabzit.docxoptions`, `tla_grabzit.animationoptions`, `tla_grabzit.tableoptions` and `tla_grabzit.client`, which allows you to use the GrabzIt API.
 
 
 ### Request a thumbnail from a service
@@ -63,7 +63,7 @@ class ThumbnailGenerator
     {
         $grabzItHandlerUrl = 'https://www.my-grabzit-thumbnail-site.com/api/thumbmail-ready';
 
-        $options = $this->container->get('tla_grabzit.options');
+        $options = $this->container->get('tla_grabzit.imageoptions');
         $options->setBrowserWidth(1024);
         $options->setBrowserHeight(768);
         $options->setFormat("png");

diff --git a/src/Resources/config/services.xml b/src/Resources/config/services.xml
@@ -5,8 +5,16 @@
     xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
 
     <services>
-        <service id="tla_grabzit.options" class="GrabzIt\GrabzItImageOptions"  public="true" />
-        <service id="GrabzIt\GrabzItImageOptions" alias="tla_grabzit.options" />
+        <service id="tla_grabzit.imageoptions" class="GrabzIt\GrabzItImageOptions"  public="true" />
+        <service id="GrabzIt\GrabzItImageOptions" alias="tla_grabzit.imageoptions" />
+        <service id="tla_grabzit.pdfoptions" class="GrabzIt\GrabzItPDFOptions"  public="true" />
+        <service id="GrabzIt\GrabzItPDFOptions" alias="tla_grabzit.pdfoptions" />
+        <service id="tla_grabzit.docxoptions" class="GrabzIt\GrabzItDOCXOptions"  public="true" />
+        <service id="GrabzIt\GrabzItDOCXOptions" alias="tla_grabzit.docxoptions" />
+        <service id="tla_grabzit.animationoptions" class="GrabzIt\GrabzItAnimationOptions"  public="true" />
+        <service id="GrabzIt\GrabzItAnimationOptions" alias="tla_grabzit.animationoptions" />
+        <service id="tla_grabzit.tableoptions" class="GrabzIt\GrabzItTableOptions"  public="true" />
+        <service id="GrabzIt\GrabzItTableOptions" alias="tla_grabzit.tableoptions" />
         <service id="tla_grabzit.client" class="GrabzIt\GrabzItClient" public="true">
             <argument></argument>
             <argument></argument>

diff --git a/tests/DependencyInjection/TlaGrabzitExtensionTest.php b/tests/DependencyInjection/TlaGrabzitExtensionTest.php
@@ -23,6 +23,6 @@ public function testLoad()
         $extension = new TlaGrabzitExtension();
         $extension->load([], $container);
         $this->assertTrue($container->hasDefinition('tla_grabzit.client'));
-        $this->assertTrue($container->hasDefinition('tla_grabzit.options'));
+        $this->assertTrue($container->hasDefinition('tla_grabzit.imageoptions'));
     }
 }