Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1116 - Adding allcontributors support to MyLA #1370

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

jonespm
Copy link
Member

@jonespm jonespm commented Apr 13, 2022

@jonespm jonespm linked an issue Apr 13, 2022 that may be closed by this pull request
@jonespm jonespm marked this pull request as ready for review April 18, 2022 13:53
@jonespm
Copy link
Member Author

jonespm commented Apr 18, 2022

Let me know if I'm missing anyone or anyone has any comments on the format and style. I probably can add a page to the wiki for (us) about how to use this copied from the allcontributors page. I was going to add the bot so it could be done through Issues, but it can also be done through the CLI.

@pushyamig
Copy link
Contributor

This Looks Great! I did not run this locally and neither I know if all contributors are included. I see all the people on the list whom I worked from before.

The branch has a conflict to be resolved for merging.

Copy link
Member

@zqian zqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I wonder whether the list can include the researcher names, even though they may not have a github account

@jonespm
Copy link
Member Author

jonespm commented Jun 10, 2022

LGTM! I wonder whether the list can include the researcher names, even though they may not have a github account

Looks like they've had that as an Issue since 2019. all-contributors/cli#325

Not sure how likely that is to get done with this spec. They'd probably have to be acknowledged somewhere else or with a different spec. I'm not sure if there's any frequently used format other than just a manual list. We could probably keep something like that in the Wiki and link to it.

@zqian
Copy link
Member

zqian commented Jun 15, 2022

Looks like they've had that as an Issue since 2019. https://github.com/all-contributors/cli/issues/325

We can certainly wait till this feature is implemented. I will close the request and approve the PR.

@jennlove-um jennlove-um removed the request for review from pushyamig June 22, 2022 18:06
@jonespm jonespm merged commit a46fa05 into tl-its-umich-edu:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an contributor.md page to MyLA project
3 participants