Clean up client<>server synchronization in stream test #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ulexus
approved these changes
Oct 23, 2024
r-n-o
reviewed
Oct 23, 2024
src/qos_core/src/io/stream.rs
Outdated
Comment on lines
374
to
375
| str::from_utf8, | ||
| sync::{Arc, Barrier}, |
src/qos_core/src/io/stream.rs
Outdated
Comment on lines
459
to
461
| // thread::spawn(move || { | ||
| // server.start(); | ||
| // }); |
There was a problem hiding this comment.
Did you mean to comment this out? I think we can remove this
jack-kearney
force-pushed
the
jack/fix-stream-test
branch
from
2cb384a to
985f96c
Compare
|
Yeah, I have no idea why it wasn't failing in CI. It was failing for me consistently locally. FWIW I just ran clippy locally and there are several (not too many) errors there as well. |
r-n-o
reviewed
Oct 23, 2024
Comment on lines
+398
to
+402
|
|
||
| // Create a barrier to synchronize between server and client | ||
| let barrier = Arc::new(Barrier::new(2)); | ||
| let server_barrier = Arc::clone(&barrier); | ||
|
|
There was a problem hiding this comment.
Same here, indentation is off (tabs vs spaces).
This tabs v space issue is there for all new lines you inserted so it's probably an editor configuration issue.
|
Closing this PR since the unit test is now stable locally. #492 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation (Problem vs. Solution)
The
stream_implements_read_write_traitswas failing locally. This makes the server<>client interaction less flakeyHow I Tested These Changes
Locally
Pre merge check list