ENG-1756: (WIP!) Malloc Benchmark Testing #476
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation (Problem vs. Solution)
This PR introduces minimalistic memory allocation benchmark testing for our base QOS images. The basic design ideas are:
benchmarking
container definition (src/images/benchmarking/Containerfile
) requires aBASE_IMAGE
argument to be provided, and uses that argument to essentially "inherit" from the base image. This guarantees that the benchmarking image is identical to the base image, with the only addition being the benchmarking binaries and the/benchmark
entrypoing.kustomize/components/qos_enclave_benchmarking
) to a shared locationkustomize/components/base
, which is consumed by both the base component and the benchmarking version. Again, this guarantees that the benchmarking component uses identical infra as the base component, with the only difference being that the container definition references the benchmarking image (see above).How I Tested These Changes
TBD
Pre merge check list