Introducing qos_net: a proxy + utilities to establish TCP connections to remote hosts/IPs from inside enclave apps
#449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emostov
reviewed
Jun 12, 2024
emostov
reviewed
Jun 12, 2024
emostov
reviewed
Jun 12, 2024
emostov
reviewed
Jun 12, 2024
emostov
reviewed
Jun 12, 2024
emostov
reviewed
Jun 12, 2024
emostov
approved these changes
Jun 18, 2024
|
Wanted to highlight this in case you wanted to merge this before me merging the resharding service: #446 (comment) |
r-n-o
force-pushed
the
rno/qos-net-proxy
branch
2 times, most recently
from
20849df to
261bd77
Compare
…emote_connection code everywhere
…should be propagated as empty, successful reads
Ulexus
reviewed
Jun 27, 2024
Ulexus
reviewed
Jun 27, 2024
emostov
reviewed
Jun 27, 2024
| deserialized_inst, inst, | ||
| "Deserialized instance differs from the original" | ||
| ); | ||
| } |
There was a problem hiding this comment.
out of scope but this reminds me that we should re-enable the lint CI job that i think got disabled during the stagex merge
There was a problem hiding this comment.
I can followup with a PR to do this, good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation (Problem vs. Solution)
This PR introduces
qos_net, a new crate containing a remote proxy and utilities to let enclave apps establish and use TCP connections to remote hosts.Here's a pretty picture to visualize where
qos_net::Proxyfits in the landscape:How I Tested These Changes
New unit and integrations tests; significant cleanups are needed!
Pre merge check list