Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test cases for StylesContext #236

Merged
merged 16 commits into from
Oct 26, 2024
Merged

Added test cases for StylesContext #236

merged 16 commits into from
Oct 26, 2024

Conversation

Suvrat1629
Copy link
Contributor

@Suvrat1629 Suvrat1629 commented Oct 20, 2024

Description

Please include a brief summary of the change and include the relevant issue(s).

Closes #232

What change does this PR introduce?

I have added a StylesContext.test.tsx file which contains test code for StylesContext.

Please select the relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to docs/code comments)

What is the proposed approach?

Please give a short overview/explanation on the approach taken to resolve the issue(s).

Checklist:

  • The commit message follows our adopted guidelines
  • Testing has been done for the change(s) added (for bug fixes/features)
  • Relevant comments/docs have been added/updated (for bug fixes/features)

Copy link
Owner

@tjtanjin tjtanjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Suvrat1629, thank you for the PR. I've left a couple of comments to be addressed. Let me know if you need any clarifications 😊

package.json Outdated Show resolved Hide resolved
src/components/ChatBotLoader.tsx Outdated Show resolved Hide resolved
viteconfig.ts Outdated Show resolved Hide resolved
jest.config.js Outdated Show resolved Hide resolved
__tests__/components/context/BotStatesContext.test.tsx Outdated Show resolved Hide resolved
@Suvrat1629
Copy link
Contributor Author

I have made the changes as you told me please tell me if you need me to make anymore changes

@tjtanjin
Copy link
Owner

I have made the changes as you told me please tell me if you need me to make anymore changes

Hey @Suvrat1629, there're still outstanding comments unresolved 😅

@Suvrat1629
Copy link
Contributor Author

Oh sorry about that

@Suvrat1629
Copy link
Contributor Author

Ok I have resolved the comments please take a look

@Suvrat1629
Copy link
Contributor Author

@tjtanjin updates?

Copy link
Owner

@tjtanjin tjtanjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tjtanjin tjtanjin merged commit 96d9563 into tjtanjin:main Oct 26, 2024
11 checks passed
RAVEYUS pushed a commit to RAVEYUS/react-chatbotify that referenced this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Add unit test cases for StylesContext
2 participants