Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Add unit tests for useSettingsInternal hook #226

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

anandxs
Copy link
Contributor

@anandxs anandxs commented Oct 19, 2024

Description

This PR introduces unit tests for the useSettingsInternal hook. These tests cover the hook's behavior, including returning settings, updating settings using helper functions, and handling edge cases like empty fields.

Closes #131

What change does this PR introduce?

Please select the relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to docs/code comments)

What is the proposed approach?

The proposed approach involves writing unit tests for useSettingsInternal. The tests use renderHook to test the hook's output and behavior, mocking necessary context and utility functions to ensure the correct configuration flow when settings are updated.

Checklist:

  • The commit message follows our adopted guidelines
  • Testing has been done for the change(s) added (for bug fixes/features)
  • Relevant comments/docs have been added/updated (for bug fixes/features)

Copy link
Owner

@tjtanjin tjtanjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😊

@tjtanjin tjtanjin merged commit 24b4a00 into tjtanjin:main Oct 20, 2024
11 checks passed
@anandxs anandxs deleted the test/usesettingsinternalhook branch October 20, 2024 11:14
RAVEYUS pushed a commit to RAVEYUS/react-chatbotify that referenced this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Add unit test cases for useSettingsInternal hook
2 participants