removed ova-list endpoint and code that was now dead

[TheMrSheldon]

No description provided.

[mam10eks]

Hi, thanks for starting the clean up.

I think the removal of build-tira-git-docker is critical, we need this image in production to run all our Github CI workloads. That this makefile uses the source code deleted in this repository likely means that we can not delete it now. It is very likely that some protobuff communication that we still use need this.

I guess the only place where we still use Protobuff at the moment (which will likely fail after this pull request) is when a run is finished it tries to communicate the run results to TIRA.

So this likely has to go hand in hand with the refactoring of the communication that you wanted to do. @kaaage and @MattiWe do you have any opinions on that?

[mam10eks]

Thanks for doing the clean up. This script should not be removed, as this is still important for our discourse deployment.

[TheMrSheldon]

Restored

[mam10eks]

Thanks for doing the clean up.

The thing below should still be important, as this is used for our production system on gitlab.
I think there might be a reason for this cp -r ../host/src/tira_host src command, so I think we can not yet remove this code, as it would mean that likely the protobuff communication is not possible anymore?

Best regards,

Maik
This script should not be removed, as this is still important for our discourse deployment.

[TheMrSheldon]

Restored

[mam10eks]

As mentioned above, this is needed for our discourse deployment.

[kaaage]

Maik, you're right. I overlooked it when was reviewing. Here pipelines/src/python/tira/git_integration/grpc_wrapper.py we still use TiraHostClient for callbacks:

    sys.path.append('/tira-git/src/tira_host')
    from grpc_client import TiraHostClient

    ret = TiraHostClient(args.tira_application_host, args.tira_application_grpc_port)
    print('GRPC client is loaded.')

We might move just host/src/tira_host/grpc_client.py into pipelines module, that should be it.

[TheMrSheldon]

Restored grpc_client.py and its dependencies

[TheMrSheldon]

I close this in favor of #656.