Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for gstreamer 1.16 by putting 1.18 specific stuff behind a build tag #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nielsavonds
Copy link

For backward compatibility, when building without any build tags, the latest gstreamer version is assumed.

…a build tag. For backward compatibility, when building without any build tags, the latest gstreamer version is assumed.
@tinyzimmer
Copy link
Owner

Thanks for doing this, it was desperately needed. I'll want some time to play with it, but I'll get back to you.

@nielsavonds
Copy link
Author

No problem! Let me know if anything needs to be changed or if you think it makes more sense to put things behind a gst118 flag instead.

@tinyzimmer
Copy link
Owner

Sorry for the delay. This looks good and works really well. The only thing I'm thinking is adding a couple lines to the README about how to use the tags. Not super critical though. I could do that later.

@RSWilli
Copy link

RSWilli commented Aug 24, 2023

@nielsavonds please recreate this PR for https://github.com/go-gst/go-gst (where future development of the bindings will take place) if you think it is necessary.

This also raises the question posed in go-gst#13 (comment) for which gstreamer version do need support. Since this PR was created some time passed and gstreamer 1.22.0 is widely available. Is this PR still relevant?

nielsavonds pushed a commit to nielsavonds/go-gst that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants