This repository has been archived by the owner on Apr 29, 2024. It is now read-only.
Calls testRTC repo for integration of testRTC tests into Slack help page #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajmacd
suggested changes
Sep 5, 2017
There was a problem hiding this comment.
Initial general comments:
- Remove the
.DS_Storefiles. - Don't change the upstream filenames.
- Remove "eslint" annotations. These third-party files won't get linted.
- Remove any "style" changes: indentation, white-space etc.
- Don't remove stuff you don't need just because it's unused.
- Remove new functionality etc that doesn't need to be here. Put it in webapp proper.
- Improve the PR description to explain what you're doing.
apappu97
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving calls webRTC tests from webapp into this separate testRTC repo in order to keep these tests sync'd with the upstream open source testRTC tests.