Set the default CLI IP for use based on a give interface name: #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows just specifying an interface and letting the first IP on that interface be used for all CLI flag defaults. Signed-off-by: Jacob Weinstock <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #544 +/- ##
===================================
- Coverage 51% 50% -1%
===================================
Files 26 26
Lines 2736 2757 +21
===================================
- Hits 1409 1396 -13
- Misses 1287 1317 +30
- Partials 40 44 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Add section on CLI and env vars and the one off note about `SMEE_PUBLIC_IP_INTERFACE`. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows just specifying an interface and letting the first IP on that interface be used for all CLI flag defaults.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: